<html>
<head><meta charset="utf-8"><title>bors · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html">bors</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="199422761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199422761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199422761">(Jun 01 2020 at 21:01)</a>:</h4>
<p>If my PR is approved and then I make a change, does it have to be re-approved? I'm assuming yes.</p>



<a name="199422798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199422798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199422798">(Jun 01 2020 at 21:02)</a>:</h4>
<p>Sorry if I'm asking too many questions, let me know if I am!</p>



<a name="199422940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199422940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199422940">(Jun 01 2020 at 21:02)</a>:</h4>
<p>Yeah it does</p>



<a name="199422996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199422996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199422996">(Jun 01 2020 at 21:03)</a>:</h4>
<p>(don't worry about asking questions, there's plenty of people that can answer them while waiting for a build)</p>



<a name="199423019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199423019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199423019">(Jun 01 2020 at 21:03)</a>:</h4>
<p>Okay :)</p>



<a name="199423068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199423068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199423068">(Jun 01 2020 at 21:03)</a>:</h4>
<p>If you feel like you're bothering people, read the "A metaquestion" topic in <a class="stream" data-stream-id="131828" href="/#narrow/stream/131828-t-compiler">#t-compiler</a> :D</p>



<a name="199423182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199423182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199423182">(Jun 01 2020 at 21:04)</a>:</h4>
<p>A lot of compiler experts said that questions never bother them</p>



<a name="199423195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199423195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199423195">(Jun 01 2020 at 21:04)</a>:</h4>
<p>Should I notify my reviewer somehow or will they just re-approve it?</p>



<a name="199423254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199423254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199423254">(Jun 01 2020 at 21:04)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> <a href="#narrow/stream/182449-t-compiler.2Fhelp/topic/bors/near/199423068">said</a>:</p>
<blockquote>
<p>If you feel like you're bothering people, read the "A metaquestion" topic in <a class="stream" data-stream-id="131828" href="/#narrow/stream/131828-t-compiler">#t-compiler</a> :D</p>
</blockquote>
<p>I read some of that thread but I just wanted to make sure :)</p>



<a name="199446648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/bors/near/199446648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/bors.html#199446648">(Jun 02 2020 at 03:14)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/182449-t-compiler.2Fhelp/topic/bors/near/199423195">said</a>:</p>
<blockquote>
<p>Should I notify my reviewer somehow or will they just re-approve it?</p>
</blockquote>
<p>Generally, they will come around to it again (because it's still assigned to them on github). Some reviewers (e.g. eddyb) also say you can ping them on zulip because they don't see gh pings as easily, but it depends on who.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>